Skip to content

feat: meta=eof for IPIP-431; ask for and expect (but not require) from http fetches#378

Closed
rvagg wants to merge 1 commit intomainfrom
rvagg/http-metadata
Closed

feat: meta=eof for IPIP-431; ask for and expect (but not require) from http fetches#378
rvagg wants to merge 1 commit intomainfrom
rvagg/http-metadata

Conversation

@rvagg
Copy link
Member

@rvagg rvagg commented Aug 11, 2023

@rvagg rvagg force-pushed the rvagg/http-metadata branch from 26954e0 to d20a604 Compare August 11, 2023 07:37
@codecov-commenter
Copy link

codecov-commenter commented Aug 11, 2023 •
edited
Loading

Codecov Report

Merging #378 (edff039) into main (26c5ca7) will decrease coverage by 0.27%.
The diff coverage is 61.76%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #378      +/-   ##
==========================================
- Coverage   77.40%   77.14%   -0.27%     
==========================================
  Files          86       87       +1     
  Lines        6423     6493      +70     
==========================================
+ Hits         4972     5009      +37     
- Misses       1194     1223      +29     
- Partials      257      261       +4
Files Changed Coverage Δ
cmd/lassie/fetch.go 31.54% <0.00%> (-0.39%) ⬇️
pkg/types/types.go 80.26% <0.00%> (+2.63%) ⬆️
pkg/retriever/httpretriever.go 73.97% <41.66%> (-11.75%) ⬇️
pkg/httputil/server.go 75.51% <50.00%> (ø)
pkg/internal/testutil/mockroundtripper.go 81.95% <78.57%> (-0.62%) ⬇️
pkg/server/http/ipfs.go 88.02% <87.50%> (ø)
pkg/httputil/metadata/metadata.go 91.66% <91.66%> (ø)
pkg/verifiedcar/verifiedcar.go 83.22% <100.00%> (ø)

@rvagg rvagg force-pushed the rvagg/http-metadata branch from d20a604 to edff039 Compare August 11, 2023 07:39
@rvagg
Copy link
Member Author

rvagg commented Aug 11, 2023 

$ go run ./cmd/lassie fetch -p --provider /ip4/127.0.0.1/tcp/3030/http/p2p/12D3KooWSQ1Qg74oMQ7uAHh8gtME2HdENJMiaoyLnjDQn3drvagg bafybeiaysi4s6lnjev27ln5icwm6tueaw2vdykrtjkwiphwekaywqhcjze/wiki/Dog
Fetching bafybeiaysi4s6lnjev27ln5icwm6tueaw2vdykrtjkwiphwekaywqhcjze/wiki/Dog from specified provider(s)
Querying indexer for bafybeiaysi4s6lnjev27ln5icwm6tueaw2vdykrtjkwiphwekaywqhcjze...
Using the specified storage provider(s):
        12D3KooWSQ1Qg74oMQ7uAHh8gtME2HdENJMiaoyLnjDQn3drvagg, Protocols: [transport-ipfs-gateway-http]
Retrieving from [12D3KooWSQ1Qg74oMQ7uAHh8gtME2HdENJMiaoyLnjDQn3drvagg] (started-retrieval)...
Retrieving from [12D3KooWSQ1Qg74oMQ7uAHh8gtME2HdENJMiaoyLnjDQn3drvagg] (connected-to-provider)...
Retrieving from [12D3KooWSQ1Qg74oMQ7uAHh8gtME2HdENJMiaoyLnjDQn3drvagg] (first-byte-received)...
Received 8 blocks / 452 KiB...
Fetched [bafybeiaysi4s6lnjev27ln5icwm6tueaw2vdykrtjkwiphwekaywqhcjze] from [12D3KooWSQ1Qg74oMQ7uAHh8gtME2HdENJMiaoyLnjDQn3drvagg]:
        Duration: 9.924479ms
          Blocks: 8
           Bytes: 452 KiB
        Checksum: 1e20fb44804ec610f99a65afbb413b0656fec971541afc411eda58c4dd34a12eba01

Running on a local version of ipld/frisbii#15 that handles meta=eof, we decode the metadata and check it against what we have and report the checksum value to stdout. If the upstream doesn't know about meta=eof then it just processes it as normal, and doesn't print the checksum.

(Note the "checksum" here is in lieu of whatever the eventual signed thing needs to be as per IPIP-431, this is for demonstration purposes for now).

/cc @bajtos @lidel

@rvagg rvagg mentioned this pull request Aug 11, 2023
Closed
@parkan
Copy link
Collaborator

parkan commented Feb 19, 2026

is this still relevant?

@rvagg
Copy link
Member Author

rvagg commented Feb 20, 2026

ipfs/specs#431 (comment)

doesn't look like it

@rvagg rvagg closed this Feb 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@rvagg @codecov-commenter @parkan